Review Request 129305: Changed shortcut of closing active tab of spilt screen from CTRL+SHIFT+S to CTRL+SHIFT+X.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129305/#review100463
-----------------------------------------------------------



+1 from me

- David Faure


On Nov. 1, 2016, 11:18 a.m., Aniketh Girish wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129305/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2016, 11:18 a.m.)
> 
> 
> Review request for Konsole and David Faure.
> 
> 
> Bugs: 354954
>     http://bugs.kde.org/show_bug.cgi?id=354954
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> The key sequence 'Ctrl+Shift+S' is ambiguous. Use 'Configure Shortcuts' from the 'Settings' menu to solve the ambiguity. This shortcut was used repeated times. 
> 
> Now its changed to CTRL+SHIFT+X. For closing active tab in the konsole of the split screen, it uses CTRL+SHIFT+X
> 
> 
> Diffs
> -----
> 
>   src/ViewManager.cpp 81ccab136953f174c4988dfbb1ff89fb56efc363 
> 
> Diff: https://git.reviewboard.kde.org/r/129305/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aniketh Girish
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20161101/436db50c/attachment.html>