[Konsole-devel] [konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)

[Antonio Russo via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=362171

--- Comment #5 from Antonio Russo <antonio.e.russo at gmail.com> ---
The patch depends on a color style to implement the "faint" intensities for
each color. I did this specifically for Linux.colorscheme (and it
should is included in the patch) but did not get around to the other themes. My
eye is not particularly suited for aesthetic choices, and the
choice of faint colors for the themes is such a choice (in particular the
solarized and light themes seemed to require some thought). Assuming
this bug gets enough attention to be included, but not enough for other people
with better aesthetics than me to work on the themes, I'll hack
up some faint colors.

I'll point out that the patch also includes in a fully functional (but
completely untested) gui for setting the faint color theme---right next
to setting the other colors and intense colors.

Notwithstanding that, the overline and strikeout font effects should function
correctly. Are you seeing those with the patch applied? If not,
could you confirm that your terminal font supports overline and strikeout
effects?

-- 
You are receiving this mail because:
You are the assignee for the bug.