[Konsole-devel] Review Request 127724: Remove hack for ensuring size before starting session

Martin Tobias Holmedahl Sandsmark martin.sandsmark at kde.org
Wed May 4 09:09:46 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127724/
-----------------------------------------------------------

(Updated May 4, 2016, 11:09 a.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole and Kurt Hindenburg.


Changes
-------

Submitted with commit b84c0f49a98cba53932c8bfc3c0a974983b14c1a by Martin T. H. Sandsmark to branch master.


Repository: konsole


Description
-------

Instead of relying on a hardcoded delay, just use a direct connection to set the window size before starting the session.


Diffs
-----

  src/Emulation.cpp 1989b16 
  src/Session.cpp 11dc01d 

Diff: https://git.reviewboard.kde.org/r/127724/diff/


Testing
-------

tested with the cases described in the bugs mentioned.


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160504/0f88dfb5/attachment.html>


More information about the konsole-devel mailing list