[Konsole-devel] Review Request 128239: Don't show silence/activity notifications when the terminal is active

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128239/#review96693
-----------------------------------------------------------



THe code looks fine.  However, are we sure there aren't reason why someone might want notifications on the active tab?  Say, start a command; walk away, do something non-computer related - waiting for notifiction.  Or is this a rare usage?

- Kurt Hindenburg


On June 18, 2016, 6:46 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128239/
> -----------------------------------------------------------
> 
> (Updated June 18, 2016, 6:46 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> This avoids getting constant notifications when using a session which has the monitor activity/silence option turned on.
> 
> You still get notifications if konsole isn't focused or you're in another session/tab.
> 
> 
> Diffs
> -----
> 
>   src/Session.cpp 0f17cea 
> 
> Diff: https://git.reviewboard.kde.org/r/128239/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160618/e5e48aee/attachment.html>