[Konsole-devel] Review Request 128168: Don't require dbus + bundle ui files in resources

Kurt Hindenburg kurt.hindenburg at gmail.com
Sat Jun 18 20:33:31 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128168/#review96691
-----------------------------------------------------------


Ship it!




Ship It!

- Kurt Hindenburg


On June 13, 2016, 5:39 a.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128168/
> -----------------------------------------------------------
> 
> (Updated June 13, 2016, 5:39 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Konsole can now start without dbus around and it will be able to find its ui files even on mac os, as they are no bundled in some resource.
> 
> 
> Diffs
> -----
> 
>   desktop/CMakeLists.txt 8409225 
>   desktop/konsole.qrc PRE-CREATION 
>   src/CMakeLists.txt 2a020b0 
>   src/main.cpp bb98074 
> 
> Diff: https://git.reviewboard.kde.org/r/128168/diff/
> 
> 
> Testing
> -------
> 
> make && make install && executed, seems to work, even without dbus and with a bit more stuff of the ui usable on Mac.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160618/f4feefbd/attachment.html>


More information about the konsole-devel mailing list