[Konsole-devel] Review Request 128153: Fix potential out of bounds read.

[Martin Tobias Holmedahl Sandsmark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128153/
-----------------------------------------------------------

Review request for Konsole.


Repository: konsole


Description
-------

The check was only done when not memory mapped, so there was a potential out of bounds read. In addition the check only printed an error, and didn't return and went ahead with the erronous read.


Diffs
-----

  src/History.cpp d00b95a 

Diff: https://git.reviewboard.kde.org/r/128153/diff/


Testing
-------

Tested running with the unlimited scrollback and various amounts of printing and scrolling to try to trigger both the mmaped and unmmaped cases.


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160611/0cba9286/attachment.html>