[Konsole-devel] Review Request 127626: Fix crash when KDBusService exits

[Martin Tobias Holmedahl Sandsmark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127626/
-----------------------------------------------------------

(Updated June 11, 2016, 11:28 a.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole, David Faure, Kurt Hindenburg, and Thiago Macieira.


Changes
-------

Submitted with commit fe334292b5402ad0fd4b934291160ece9a12d953 by Martin T. H. Sandsmark to branch master.


Repository: konsole


Description
-------

Fix crash when KDBusService exits.

This is a bit of an ugly workaround, but it seems to work.

I'll paste in my comment from https://git.reviewboard.kde.org/r/127625/ here:

    It seems like it is this that it happening: https://bugreports.qt.io/browse/QTBUG-48709

    From my understanding it can't really be fixed, short of somehow getting KDBusService to delete the QApplication before calling exit(), which might get nasty with QApplications allocated on the stack?

    In any case it seems to be a general bug with KDBusService and how it is supposed to be used, not something that we can easily fix in konsole.


Diffs
-----

  src/main.cpp 5e1420e37363454cf5e7886a82381cb9eb4447d8 

Diff: https://git.reviewboard.kde.org/r/127626/diff/


Testing
-------

Tested by forcing it to open a new window in an existing session (commenting out line 237 in main.cpp), and running under valgrind to verify the deletion.


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160611/d31db0b3/attachment.html>