[Konsole-devel] Review Request 128129: Don't pass $SHELL as argument to $SHELL in fallback profile.

Kurt Hindenburg kurt.hindenburg at gmail.com
Sat Jun 11 01:53:43 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128129/#review96350
-----------------------------------------------------------


Ship it!




Ship It!

- Kurt Hindenburg


On June 8, 2016, 8:48 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128129/
> -----------------------------------------------------------
> 
> (Updated June 8, 2016, 8:48 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> For some reason (that I have yet to determine) somehow Konsole seem to have lost the profiles (in memory, they're still on disk).
> 
> Which led to konsole complaining that it couldn't launch /bin/bash with the argument /bin/bash: https://iskrembilen.com/screenshots/konsolefail.png
> 
> This looks wrong to me. So this is just a simple fix for that.
> 
> 
> Diffs
> -----
> 
>   src/Profile.cpp f98f960 
> 
> Diff: https://git.reviewboard.kde.org/r/128129/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160611/5831c07e/attachment.html>


More information about the konsole-devel mailing list