[Konsole-devel] [konsole] [Bug 198175] Konsole should set blur region for the new kwin effect

[Mark via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=198175

--- Comment #76 from Mark <markg85 at gmail.com> ---
(In reply to Eike Hein from comment #75)
> > konsole shouldn't set the blur region if the parent app in which it lives sets the blur (Yakuake for instance).
> 
> No, I'm saying when TerminalDisplay sets the blur region, it needs to not
> replace the blur region but merge its intended blur region with whatever is
> already set. This is technically still problematic in the case where
> TerminalDisplay's blur region fully contains a blur region "write" by
> someone else that it might later unset when disabling blur in the profile,
> but that's an extreme edge case probably not worth worrying too much about -
> I don't know of any existing app where it would actually be a problem.

But there is a catch.. How do you get the blur region that might already be
set?
There is no function for that in KWindowSystem (which is used to set the
region).

If you can clarify this last thing with a possible way to implement it, then i
can go right ahead and make a nice patch :)
> 
> > That way, if it gets embedded it should still behave nicely when the parent sets the blur hint for the region it wants.
> 
> Then Dolphin needs it's own "Blur behind terminal" option - not really
> smart. It's nicer to place it in the Konsole profile options.
> 
> The algo is basically:
> 
> - catch relevant events for widget geometry change
> - get current blur region
> - map old widget geo to window
> - remove from blur region
> - map new widget geo to window
> - add to blur region
> - set blur region

Thank you for that elaborate explanation. That certainly makes it clear how you
want it to be implemented.

-- 
You are receiving this mail because:
You are the assignee for the bug.