[Konsole-devel] Review Request 128416: Send EOF before sending SIGHUP when closing

[Martin Tobias Holmedahl Sandsmark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128416/
-----------------------------------------------------------

(Updated July 11, 2016, 10:59 a.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole, Kurt Hindenburg and Oswald Buddenhagen.


Changes
-------

Submitted with commit 2f1c8cf397be6c91fcd60234740d9727650c1a87 by Martin T. H. Sandsmark to branch master.


Bugs: 185140
    http://bugs.kde.org/show_bug.cgi?id=185140


Repository: konsole


Description
-------

According to http://permalink.gmane.org/gmane.comp.shells.bash.bugs/12602 (from https://bugs.kde.org/show_bug.cgi?id=185140), sending EOF is the appropriate way of telling e. g. bash to quit.

I wasn't able to get KPtyProcess to send that in a nice way (calling setStandardInputFile(QProcess::nullDevice(), for example), so we fetch the EOF character manually with tcgetattr and send that.


Diffs
-----

  src/Pty.h 0e7c478 
  src/Pty.cpp eaeda07 
  src/Session.cpp 768dc06 

Diff: https://git.reviewboard.kde.org/r/128416/diff/


Testing
-------

Running backgrounded processes (e. g. launching «kate&») and then closing the tab/window now leaves the backgrounded tasks running, which is apparently The Right Thing.


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160711/7e3ee06b/attachment.html>