[Konsole-devel] [konsole] [Bug 185140] Konsole should send EOF before closing tabs

Martin Sandsmark via KDE Bugzilla bugzilla_noreply at kde.org
Mon Jul 11 10:59:41 UTC 2016


https://bugs.kde.org/show_bug.cgi?id=185140

Martin Sandsmark <martin.sandsmark at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/kons
                   |                            |ole/2f1c8cf397be6c91fcd6023
                   |                            |4740d9727650c1a87
             Status|CONFIRMED                   |RESOLVED

--- Comment #10 from Martin Sandsmark <martin.sandsmark at kde.org> ---
Git commit 2f1c8cf397be6c91fcd60234740d9727650c1a87 by Martin T. H. Sandsmark.
Committed on 11/07/2016 at 10:57.
Pushed by sandsmark into branch 'master'.

Send EOF when closing first, before SIGHUP

According to the bash maintainer sending EOF is the appropriate way of
telling e. g. bash to quit:
    http://permalink.gmane.org/gmane.comp.shells.bash.bugs/12602

I wasn't able to get KPtyProcess to send that in a nice way (calling
setStandardInputFile(QProcess::nullDevice(), for example), so we fetch
the EOF character manually with tcgetattr and send that.
REVIEW: 128416

M  +16   -0    src/Pty.cpp
M  +5    -0    src/Pty.h
M  +9    -0    src/Session.cpp

http://commits.kde.org/konsole/2f1c8cf397be6c91fcd60234740d9727650c1a87

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the konsole-devel mailing list