[Konsole-devel] Review Request 128393: Improve filter updating

[Martin Tobias Holmedahl Sandsmark]

> On July 10, 2016, 7:51 p.m., Kurt Hindenburg wrote:
> > Have you done any calculations to verify it is better?  Before the filers were only updated on mouse mouse.  Now it is every screen change.

The idea is to not to do it on all mouse updates, only when needed on mouse updates, and also not display the filters if they are out of date. The only thing that should happen on screen changes now is setting the _filterUpdateRequired variable to true, which leads to the filters not being displayed until re-processed, which happens the next time the mouse moves, unless I fucked something up.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128393/#review97263
-----------------------------------------------------------


On July 7, 2016, 6:48 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128393/
> -----------------------------------------------------------
> 
> (Updated July 7, 2016, 6:48 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> This should update filters less often, and also hopefully fix the issue where underlined links get stuck while scrolling. Maybe.
> 
> 
> Diffs
> -----
> 
>   src/SessionController.h 7b357e5 
>   src/SessionController.cpp 58e2f81 
>   src/TerminalDisplay.h cfb74ed 
>   src/TerminalDisplay.cpp a6ac56e 
> 
> Diff: https://git.reviewboard.kde.org/r/128393/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160711/b1e87b58/attachment.html>