[Konsole-devel] Review Request 128405: Code cleanup for additional rendition flags

[Antonio Russo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128405/
-----------------------------------------------------------

(Updated July 10, 2016, 10:06 p.m.)


Review request for Konsole.


Changes
-------

Fall back to normal intensity color (or default color) if a color
definition is missing from a color scheme.

Incorporated Martin Tobias Holmedahl Sandsmark's comments.


Summary (updated)
-----------------

Code cleanup for additional rendition flags


Repository: konsole


Description (updated)
-------

Removed outdated comments and unused constant RE_INTENSIVE

Replace a quint8 flag type with a uniform RenditionFlag
typedef (now quint16) in preparation for additional flags.

Add faint intensity support (SGR 2)

Four changes implementing faint intensity:
a) A new rendition flag RE_FAINT
b) Vt102Emulation to actually render text with
   a different color
c) ColorScheme support for "faint" colors
d) ColorSchemeEditor support

ColorScheme updates for faint intensities


Add strikeout support (SGR 9)


Add conceal support (SGR 8)


Add overline support (SGR 53)


Use normal intensity color by default

Incorporate comment by Martin Sandsmark handling
the situation where a color scheme fails to
define particular color.


Diffs (updated)
-----

  data/color-schemes/BlackOnLightYellow.colorscheme 289452df8731aba27bde80b70687ad01128a8da6 
  data/color-schemes/BlackOnRandomLight.colorscheme 8184e29c54d19c45d47b24274099c4a80140adce 
  data/color-schemes/BlackOnWhite.colorscheme be9ba2f193eb6a5e15f4ee12d06d2184c520601a 
  data/color-schemes/BlueOnBlack.colorscheme f72da32da5472c2aefb9da8754fe20ed7ccff6da 
  data/color-schemes/Breeze.colorscheme a9031d6ae1f260f5d8bb394e542cd38cbcad3173 
  data/color-schemes/DarkPastels.colorscheme 110f72bc26e929db87570ebd8fd5f382c70d0359 
  data/color-schemes/GreenOnBlack.colorscheme df0f3b309e5d93ea052114ad7aec64191ac340dc 
  data/color-schemes/Linux.colorscheme 3cb0381132449bd61daccaa591fd6b3460326bb0 
  data/color-schemes/RedOnBlack.colorscheme 207f892de3e2290e7ef1be8aa7c4d847b26f66c8 
  data/color-schemes/Solarized.colorscheme e3f0aee0478c0e77231c3463ef2d8059b6dbdd55 
  data/color-schemes/SolarizedLight.colorscheme ea064f4e4aa519a0652ba962cfd2f57906681758 
  data/color-schemes/WhiteOnBlack.colorscheme 7307c5d40d741a9fa188468c461cddbb90179e86 
  src/Character.h a722bafb47b166defc88324bc58f33017630cd07 
  src/CharacterColor.h 8557e1bec3f04b72c89831f12f6e283275983952 
  src/ColorScheme.cpp 1281433dc06274d970b96162711b78938695be09 
  src/ColorSchemeEditor.cpp 9e227a4a365779372ff15cc4af77e0118ce30fec 
  src/History.h dcd38195101a6f95b22e7922d2a2268562ec1eed 
  src/Screen.h f73add14ecf7787dabe07850c586d970729367f5 
  src/Screen.cpp ffc3fd15f158079373b47d261fd33fc9f4a95192 
  src/TerminalCharacterDecoder.h 18dd0302ef23e6cdb684c44952d4adddc432e6dc 
  src/TerminalDisplay.cpp d3d4f337d8d8c2878f76a0b52d0f44bc809e4c1d 
  src/Vt102Emulation.cpp 6e1734b451f95e0b498218d992f8b0ee007e5170 
  src/autotests/CharacterColorTest.cpp 0fefa607a5ab75794b463a0c804cb619bddbe5c5 

Diff: https://git.reviewboard.kde.org/r/128405/diff/


Testing
-------

I have been running this patchset for the last several months without issue.


Thanks,

Antonio Russo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160710/3efb3b08/attachment-0001.html>