[Konsole-devel] Review Request 128416: Send EOF before sending SIGHUP when closing

[Martin Tobias Holmedahl Sandsmark]

> On July 10, 2016, 8:11 a.m., Oswald Buddenhagen wrote:
> > src/Session.cpp, line 828
> > <https://git.reviewboard.kde.org/r/128416/diff/1/?file=471487#file471487line828>
> >
> >     // The PTY is not integrated with the process' waitFor*() functions.
> >     _shellProcess->pty()->waitForBytesWritten();
> >     
> >     i think that also obsoletes the surrounding comments, which make no sense to me.

Thanks, that works much better. I completely misunderstood the comment in KPtyProcess, I thought it was the waitForFinished() function that didn't work for some reason...


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128416/#review97250
-----------------------------------------------------------


On July 9, 2016, 10:55 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128416/
> -----------------------------------------------------------
> 
> (Updated July 9, 2016, 10:55 p.m.)
> 
> 
> Review request for Konsole, Kurt Hindenburg and Oswald Buddenhagen.
> 
> 
> Bugs: 185140
>     http://bugs.kde.org/show_bug.cgi?id=185140
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> According to http://permalink.gmane.org/gmane.comp.shells.bash.bugs/12602 (from https://bugs.kde.org/show_bug.cgi?id=185140), sending EOF is the appropriate way of telling e. g. bash to quit.
> 
> I wasn't able to get KPtyProcess to send that in a nice way (calling setStandardInputFile(QProcess::nullDevice(), for example), so we fetch the EOF character manually with tcgetattr and send that.
> 
> In addition KPtyProcess doesn't support waitForFinished(), so we have to spin the event loop manually for KPtyProcess to notice that the child is finished.
> 
> 
> Diffs
> -----
> 
>   src/Pty.h 0e7c478 
>   src/Pty.cpp eaeda07 
>   src/Session.cpp 768dc06 
> 
> Diff: https://git.reviewboard.kde.org/r/128416/diff/
> 
> 
> Testing
> -------
> 
> Running backgrounded processes (e. g. launching «kate&») and then closing the tab/window now leaves the backgrounded tasks running, which is apparently The Right Thing.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160710/db160f03/attachment.html>