[Konsole-devel] Review Request 128394: Improve the look of search results

[Martin Tobias Holmedahl Sandsmark]

> On July 8, 2016, 4:45 p.m., Kurt Hindenburg wrote:
> > I realize this is likely personal tastes.  I don't like the change of the background to a darker brown-ish color.  What do you think about keeping the bg color the same and changing the other aspects?

I don't think it makes it brown, it should just darken it. And without doing something like that it's hard to indicate the current line and other hits in a way that works across color schemes (the background color and foreground color isn't uniform etc.).

But we can just let this wait and see if we come up with a better idea that works and looks well in all configurations, I guess.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128394/#review97218
-----------------------------------------------------------


On July 7, 2016, 11:13 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128394/
> -----------------------------------------------------------
> 
> (Updated July 7, 2016, 11:13 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> https://iskrembilen.com/screenshots/konsolesearch.png
> 
> 
> Diffs
> -----
> 
>   src/SessionController.cpp 58e2f81 
>   src/TerminalDisplay.cpp ee79f7e 
> 
> Diff: https://git.reviewboard.kde.org/r/128394/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160708/5196dc98/attachment.html>