[Konsole-devel] Review Request 128396: Improvements to file matching

[Martin Tobias Holmedahl Sandsmark]

> On July 8, 2016, 4:53 p.m., Kurt Hindenburg wrote:
> > Can you give some examples to test with?

Well, running (a modern) ls in a folder with filenames with spaces in them should be good enough for the space part, it prints them like e.g. «'Untitled 1.odt'».

For full name files known and prefixes, some examples should be files named README.*, CREDITS, and files named massif.out.* here at least (the last is probably because I have massif-visualizer installed). But it depends on what applications you have installed and what file name patterns they register.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128396/#review97219
-----------------------------------------------------------


On July 7, 2016, 8:20 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128396/
> -----------------------------------------------------------
> 
> (Updated July 7, 2016, 8:20 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Include glob patterns that are either complete filenames or prefixes instead of just suffixes, also handle filenames with spaces, as `ls` has started to show them (wrapped in '').
> 
> 
> Diffs
> -----
> 
>   src/Filter.cpp 062a459 
> 
> Diff: https://git.reviewboard.kde.org/r/128396/diff/
> 
> 
> Testing
> -------
> 
> A lot. KRegexEditor, massif, QElapsedTimer, etc.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160708/4594ecf1/attachment-0001.html>