[Konsole-devel] Review Request 128399: Make it possible to manually dismiss output suspended messages.

[Martin Tobias Holmedahl Sandsmark]

> On July 8, 2016, 2:56 a.m., Kurt Hindenburg wrote:
> > So is the idea that after 10 seconds, the message disappears and the user might be confused about why the output is suspended?  So now, they must manually remove the message.
> > If so, the only issue I see is that the message hides the top line.
> > 
> > I wonder if adding a X (button) might be better.

> So is the idea that after 10 seconds, the message disappears and the user might be confused about why the output is suspended?

Yes, especially if they switch back and forth.

> So now, they must manually remove the message.

Not only must, but they actually can. If someone is interested in what is in the top line it is pretty annoying to have to wait 10 seconds every time.


> If so, the only issue I see is that the message hides the top line.

Well, it already does before this patch?


> I wonder if adding a X (button) might be better.

More complex though, I think?


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128399/#review97183
-----------------------------------------------------------


On July 8, 2016, 2:44 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128399/
> -----------------------------------------------------------
> 
> (Updated July 8, 2016, 2:44 a.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Instead of having to wait 10 seconds, the use can now just directly click to dismiss.
> 
> I also had some trouble with the label stealing focus, so I set a focus proxy.
> 
> 
> Diffs
> -----
> 
>   src/TerminalDisplay.cpp 8e43b7e 
> 
> Diff: https://git.reviewboard.kde.org/r/128399/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160708/d05be21d/attachment.html>