[Konsole-devel] Review Request 128394: Improve the look of search results

Kurt Hindenburg kurt.hindenburg at gmail.com
Thu Jul 7 21:53:59 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128394/#review97180
-----------------------------------------------------------



Tested w/ the Light Solarized  and Black/White color scheme; with the patch, the output is not good at all (too dark).

W/ the Black/white, you can't see the "highlight all entries"

what was your general idea for improving the output?

- Kurt Hindenburg


On July 7, 2016, 7:48 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128394/
> -----------------------------------------------------------
> 
> (Updated July 7, 2016, 7:48 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> https://iskrembilen.com/screenshots/konsolesearch.png
> 
> 
> Diffs
> -----
> 
>   src/SessionController.cpp 58e2f81 
>   src/TerminalDisplay.cpp ee79f7e 
> 
> Diff: https://git.reviewboard.kde.org/r/128394/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160707/6ea19258/attachment-0001.html>


More information about the konsole-devel mailing list