[Konsole-devel] Review Request 128346: Port to QRegularExpression
Martin Tobias Holmedahl Sandsmark
martin.sandsmark at kde.org
Thu Jul 7 18:10:58 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128346/
-----------------------------------------------------------
(Updated July 7, 2016, 6:10 p.m.)
Review request for Konsole and Kurt Hindenburg.
Changes
-------
Rebased
Repository: konsole
Description
-------
Port away from using QRegExp to QRegularExpression. The result is a bit better performance, a bit more readable code (imho) and also no more relying on mutable state in static objects (like in the keyboard translator parser).
Diffs (updated)
-----
src/Filter.h 1790bd9
src/Filter.cpp b3f0186
src/KeyboardTranslator.cpp 3effb72
src/Profile.cpp 9b2201f
src/SessionController.h 7b357e5
src/SessionController.cpp 58e2f81
Diff: https://git.reviewboard.kde.org/r/128346/diff/
Testing
-------
Tested all the affected code individually.
Thanks,
Martin Tobias Holmedahl Sandsmark
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160707/2a29f696/attachment.html>
More information about the konsole-devel
mailing list