[Konsole-devel] Review Request 128348: Implement URL hints

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128348/#review97164
-----------------------------------------------------------


Ship it!




Very interesting - didn't know this was possible.  It appears to work as expected - tested in KPart as well.  The only minor nitpick is that mult-line URLs have multiple #s.  Don't let that stop from committing.

- Kurt Hindenburg


On July 2, 2016, 8:45 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128348/
> -----------------------------------------------------------
> 
> (Updated July 2, 2016, 8:45 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Implements a feature from e. g. good old Konqueror/KHTML, where you got a number overlaid all links when pressing ctrl, and then you could press ctrl+number to activate that link.
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h 00ab5c5 
>   src/EditProfileDialog.cpp 331f2c8 
>   src/EditProfileDialog.ui 9ff593a 
>   src/Profile.h e6ba055 
>   src/Profile.cpp 287b047 
>   src/TerminalDisplay.h 82d5544 
>   src/TerminalDisplay.cpp 3272122 
>   src/ViewManager.cpp 16e1eed 
> 
> Diff: https://git.reviewboard.kde.org/r/128348/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160706/3a419aa4/attachment-0001.html>