[Konsole-devel] Review Request 128351: Implement support for getting the current URL from OSC 7

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128351/#review97162
-----------------------------------------------------------


Ship it!




looks good

- Kurt Hindenburg


On July 6, 2016, 4:25 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128351/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 4:25 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Bugs: 336618
>     http://bugs.kde.org/show_bug.cgi?id=336618
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Implements support for the OSC 7 "standard" for tracking open directories in the terminal (e. g. for bookmarks).
> 
> From the bug report, this is apparently what the osx terminal, iterm and gnome terminal uses to keep track of stuff. I kept the existing tracking as a fallback.
> 
> 
> Diffs
> -----
> 
>   src/Session.h 6c63175 
>   src/Session.cpp 0520628 
> 
> Diff: https://git.reviewboard.kde.org/r/128351/diff/
> 
> 
> Testing
> -------
> 
> I don't know what actually passes this, but now konsole updates properly when I send the magic escape sequence.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160706/2e1a1f71/attachment.html>