[Konsole-devel] Review Request 128299: add a debian compat option

[Kurt Hindenburg]

> On July 3, 2016, 2:48 p.m., Kurt Hindenburg wrote:
> > Someone from Debian had asked about providing a new patch which I did for them.  However, I've been reluctant to add distro specific code in Konsole.
> 
> Harald Sitter wrote:
>     I'd generally agree. In this particular case the code is coming at pretty much no cost to us. Presumably konsole will always have cmdline arguments and as such getting -T is a matter of copy and paste and changing the strings. In fact as long as we have a way to set options hidden it doesn't even matter what is in the strings (e.g. this option isn't using i18n() because of that).
>     What remains is the plus side of having an in-code reminder to not use -T for anything else so we don't cause incompatibility with the debian policy by accident and the fact that all debian derived systems (of which there are a few ;)) do not need to carry and update the -T patch as updating pathes is ever so much more work than a simple copy and paste in-code.
>     It's arguably also in our interest to have this sorted on a Konsole level as we can make sure that it is hidden, so debian-based systems don't list it in --help so users don't try it and then notice that the option doesn't work and then report bug reports on bugs.kde.org about this. I think everyone will be happier if we do it properly instead of hoping that someone is going to do it proper enough to not annoy anyone :)
>     
>     That said, I am not particularly attached to this since I think the debian policy is stupidly overzealous in specifying -T.

OK, I agree it would be helpful to avoid future code. Go ahead


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128299/#review97060
-----------------------------------------------------------


On June 28, 2016, 8:14 a.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128299/
> -----------------------------------------------------------
> 
> (Updated June 28, 2016, 8:14 a.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> debian policy for reasons beyond my apprehension wants a -T option to
> set the window title (like in xterm).
> to make debian's (and derivate's) life easier let's support a no-op
> -T option but hide it. this option will not appear in --help output
> but be accepted by the parser all the same.
> 
> this enables Debian and friends to drop a long standing useless patch
> and at the same time prevents us from introducing a conflicting -T in
> the future.
> 
> 
> Diffs
> -----
> 
>   src/main.cpp d8b4b2964471a8edc1b711bbc8220624d33690bb 
> 
> Diff: https://git.reviewboard.kde.org/r/128299/diff/
> 
> 
> Testing
> -------
> 
> - builds
> - not listed in --help
> - konsole -T yolo works
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160705/5e7ee374/attachment.html>