[Konsole-devel] Review Request 128241: Updated version of the file filter patch

[Sune Vuorela]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128241/#review97092
-----------------------------------------------------------



dunno enough about this area to approve it.


src/Filter.h (line 321)
<https://git.reviewboard.kde.org/r/128241/#comment65587>

    Why tracked as a qpointer?


- Sune Vuorela


On July 3, 2016, 12:36 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128241/
> -----------------------------------------------------------
> 
> (Updated July 3, 2016, 12:36 a.m.)
> 
> 
> Review request for Konsole and Adam Treat.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> I ported the patch from here: https://git.reviewboard.kde.org/r/114376/
> 
> Original comment:
> Implement a new file filter using POSIX Portable Filename Character Set
> along with KDE's mimetype database of file extension blobs that filters
> text matching a POSIX portable pathname and underlines it very much like
> links.
>     
> Info on the character set allowed can be found at this link:
> http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_267
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.ui 9ff593a 
>   src/Filter.h 8d125f2 
>   src/Filter.cpp 789c4cd 
>   src/SessionController.h 32a9e7c 
>   src/SessionController.cpp b37937d 
> 
> Diff: https://git.reviewboard.kde.org/r/128241/diff/
> 
> 
> Testing
> -------
> 
> Clicked on a lot of files.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160704/11beed7d/attachment.html>