[Konsole-devel] Review Request 128342: Write profiles to the correct directory

[Wolfgang Bauer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128342/
-----------------------------------------------------------

(Updated July 3, 2016, 6:28 p.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole and Kurt Hindenburg.


Changes
-------

Submitted with commit b9261c58ab2cf91ec090e4ad15064286a5366642 by Kurt Hindenburg to branch master.


Bugs: 364336
    http://bugs.kde.org/show_bug.cgi?id=364336


Repository: konsole


Description
-------

QStandardPaths::AppLocalDataLocation includes the application name, which is different than "konsole" when the kpart is embedded in another application.
Profiles are only read from QStandardPath::GenericDataLocation+"/konsole" though, so modifying profiles didn't work in that case (if built against Qt 5.4 or higher).

Revert to using QStandardPath::GenericDataLocation when writing a profile to restore the old behavior and make profile changes actually being remembered in applications that embed konsole-part.


Diffs
-----

  src/ProfileWriter.cpp 32b8962 

Diff: https://git.reviewboard.kde.org/r/128342/diff/


Testing
-------

Run yakuake, right-click on the embedded konsole-part, choose "Edit Current Profile" and change it. ("Manage Profiles" doesn't work because of bug#360072)
The changes are stored to ~/.local/share/konsole/ now and remembered across restarts.

It still works in konsole too.


Thanks,

Wolfgang Bauer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160703/e57ed7a6/attachment.html>