[Konsole-devel] Review Request 126921: Fix programming ligature support by allowing to use variable-width fonts

[Stefan Seemayer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126921/
-----------------------------------------------------------

(Updated Jan. 30, 2016, 8:55 p.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole.


Changes
-------

Submitted with commit 1e2dc1083c1fe3b1c7acd028832c70bf8006848f by Kurt Hindenburg to branch master.


Repository: konsole


Description
-------

For users of monospace fonts with programming ligature support such as
Hasklig, FiraCode or PragmataPro, commit d59ad5cd8ad7cdaab2ba5df59a786d475a535db5
makes Konsole freeze on startup if they had set a variable-width font
in their default profile because no font is being set on startup.

Instead of refusing to set the variable-width font necessary for
ligatures to work, emit a warning message and continue setting the font.
This will restore support for ligature fonts.


Diffs
-----

  src/TerminalDisplay.cpp 536aea6 

Diff: https://git.reviewboard.kde.org/r/126921/diff/


Testing
-------

Commit causing the problems was identified using git-bisect on ArchLinux x86-64 rolling. Patch applies and compiles on git-HEAD at da573a8a90e7721bd1929a929b694db9292ad36d .


Thanks,

Stefan Seemayer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160130/95c2b44c/attachment-0001.html>