[Konsole-devel] Review Request 126924: Fix for not using window size from profile when user deactivated loading old size

[Roman Gilg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126924/
-----------------------------------------------------------

(Updated Jan. 29, 2016, 7:49 p.m.)


Review request for Konsole.


Changes
-------

Now it also works, when detaching tab or opening new tab from 'File' menu.


Bugs: 345403
    http://bugs.kde.org/show_bug.cgi?id=345403


Repository: konsole


Description
-------

Bug 345403: When launching Konsole with deactivated "Use current window size on next startup", the window doesn't use the specified size from profile.

In my shallow understanding that is the case, because only the sizeHint() of the widget is set, but the sizePolicy() is not enforcing it. Instead we need to manually resize the widget.

Additionally I deactivated a property check, which is only needed on first launch of the application after install and should be ignored in my opinion. Please tell me to revert otherwise.


Diffs (updated)
-----

  src/Application.h ae9b1fe 
  src/Application.cpp 10f11a4 

Diff: https://git.reviewboard.kde.org/r/126924/diff/


Testing
-------

System: Arch, all updates.

- Launched application with and without reloading of old size
- Used option --new-tab, that doesn't change size
- Regarding the property check: Launched application with maximal height and width without problems


Thanks,

Roman Gilg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160129/3a585484/attachment.html>