[Konsole-devel] Review Request 126921: Fix programming ligature support by allowing to use variable-width fonts

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126921/#review91737
-----------------------------------------------------------



I'm not sure this is a good idea.  Using variable-width fonts will cause a lot of other issues w/ displaying text, colors, selecting text, etc.

Can the issue you're having be fixed another way?

- Kurt Hindenburg


On Jan. 28, 2016, 2:53 p.m., Stefan Seemayer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126921/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2016, 2:53 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> For users of monospace fonts with programming ligature support such as
> Hasklig, FiraCode or PragmataPro, commit d59ad5cd8ad7cdaab2ba5df59a786d475a535db5
> makes Konsole freeze on startup if they had set a variable-width font
> in their default profile because no font is being set on startup.
> 
> Instead of refusing to set the variable-width font necessary for
> ligatures to work, emit a warning message and continue setting the font.
> This will restore support for ligature fonts.
> 
> 
> Diffs
> -----
> 
>   src/TerminalDisplay.cpp 536aea6 
> 
> Diff: https://git.reviewboard.kde.org/r/126921/diff/
> 
> 
> Testing
> -------
> 
> Commit causing the problems was identified using git-bisect on ArchLinux x86-64 rolling. Patch applies and compiles on git-HEAD at da573a8a90e7721bd1929a929b694db9292ad36d .
> 
> 
> Thanks,
> 
> Stefan Seemayer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160129/8433f6f4/attachment.html>