[Konsole-devel] Review Request 126808: [WIP] Port away from KDELibs4Support

[Kai Uwe Broulik]

> On Jan. 19, 2016, 2:08 vorm., Dāvis Mosāns wrote:
> > src/main.cpp, line 167
> > <https://git.reviewboard.kde.org/r/126808/diff/1/?file=434618#file434618line167>
> >
> >     No idea about this, maybe it's not needed anymore at all?

I *think* QCommandLineParser / Q(Gui,Core)Application handle the Qt args automatically


> On Jan. 19, 2016, 2:08 vorm., Dāvis Mosāns wrote:
> > src/MainWindow.cpp, line 534
> > <https://git.reviewboard.kde.org/r/126808/diff/1/?file=434615#file434615line534>
> >
> >     No clue what's this...

I guess this is when Konsole is about to be closed on logout it does not asks for confirmation (eg. "app is still running" or "you have multiple tabs"). I'm not sure how to implement this using Qt's mechanisms.

I guess have a look at https://doc.qt.io/qt-5/qsessionmanager.html#allowsInteraction ie. qApp commitDataRequest to replicate this behavior, not sure.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126808/#review91296
-----------------------------------------------------------


On Jan. 19, 2016, 1:59 vorm., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126808/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2016, 1:59 vorm.)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Port away from KDELibs4Support
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7feee0d7629d3747d8d83d35ceefc1ee75aebb4b 
>   src/Application.h ae9b1fe5f00ca54d0c74038506264e7787f39df5 
>   src/Application.cpp 10f11a46e7d047ae4e757f8f5d325cd57b546d6e 
>   src/CMakeLists.txt 679807931585644000be0a38ccd67fe5158b3fa5 
>   src/MainWindow.h 500b39561116ce4ce72fa7d3a742c5a57c2b49ef 
>   src/MainWindow.cpp 822e45d57635dd7328eaec7db3eae41cdf19e61b 
>   src/SessionController.h 02f51d9db679eb32d6403ee1103b40842b0c668e 
>   src/SessionListModel.cpp fb28bb806d270b019978684bfeb1052a83afea03 
>   src/main.cpp 5e1420e37363454cf5e7886a82381cb9eb4447d8 
>   src/settings/ProfileSettings.cpp d6dafbf17285192727679f92e91744e6c00b2c50 
> 
> Diff: https://git.reviewboard.kde.org/r/126808/diff/
> 
> 
> Testing
> -------
> 
> compiles/builds but not tested...
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160201/58f306ef/attachment-0001.html>