Review Request 129647: Add --nofork as compatibility alias for --separate

Harald Sitter sitter at kde.org
Tue Dec 13 08:21:52 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129647/
-----------------------------------------------------------

Review request for Konsole.


Repository: konsole


Description
-------

In previous incarnations of kuniqueapplication it used to inject a common
command option --nofork which is meant to bypass single-instance behavior.
Given that konsole can and is being invoked from scripts they may well want
to ensure that the fork they created is the actual instance of konsole.
i.e. to monitor return values and life time

Presently, since the options are divergent between konsole4 and konsole5,
scripts are either incompatible with older konsoles or with newer konsoles.
To make life easier for everyone add an compat alias --nofork, which
behaves exactly like separate.

(this unbreaks steam, which is a notable recent offender of falling into
 this particular trap)


Diffs
-----

  src/Application.cpp 5b352ec9b10899b44abbd6ee1609422ef1434620 
  src/main.cpp 26d3da990b6aee564c0c9a237a56a65b1d372508 

Diff: https://git.reviewboard.kde.org/r/129647/diff/


Testing
-------

builds + noforks + separates

poor steam also is happily opening a konsole now


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20161213/b7851781/attachment-0001.html>


More information about the konsole-devel mailing list