Review Request 128789: Fix checking of foreground process

[Martin Tobias Holmedahl Sandsmark]

> On Aug. 28, 2016, 3:42 p.m., Kurt Hindenburg wrote:
> > looks fine - is there any diff/reason to use == nullptr vs a simple if ()

erh, not really. I'm not really sure why I did it like that.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128789/#review98750
-----------------------------------------------------------


On Aug. 28, 2016, 1:29 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128789/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2016, 1:29 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Bugs: 367746
>     http://bugs.kde.org/show_bug.cgi?id=367746
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> The old method of checking it has unnecessary overhead (doing a full process info update), and wasn't very reliable.
> 
> Instead just get the original shell PID from QProcess (via KProcess), and the foreground process from the PTY.
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.cpp 6f56014 
>   src/Session.cpp 14a0fbb 
> 
> Diff: https://git.reviewboard.kde.org/r/128789/diff/
> 
> 
> Testing
> -------
> 
> It fixes https://bugs.kde.org/show_bug.cgi?id=367746 for me, also added debug output to print the shell PID and the current process PID to verify that it acted correctly when doing stuff.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160828/d882a750/attachment-0001.html>