Review Request 128787: Use QProcess::processId() instead of KProcess::pid()

[Martin Tobias Holmedahl Sandsmark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128787/
-----------------------------------------------------------

(Updated Aug. 28, 2016, 1:19 p.m.)


Status
------

This change has been discarded.


Review request for Konsole.


Repository: konsole


Description
-------

The reason for using KProcess::pid() was that it returned the actual PID
    on Windows while QProcess::pid() returned a _PROCESS_INFORMATION
    pointer.
    
    However now QProcess::pid() which KProcess uses is obsolete/deprecated,
    and QProcess::processId() returns what we want, the code in
    KProcess::pid() and QProcess::processId() is now identical.

Also changes the PID usage to qint64, which is what Qt uses for PIDs.


Diffs
-----

  src/Part.h bbe6510 
  src/Part.cpp 07f8cf7 
  src/ProcessInfo.h 3590651 
  src/ProcessInfo.cpp 6a5ac2d 
  src/Pty.h 5996f95 
  src/Pty.cpp f76edfb 
  src/Session.h 397b515 
  src/Session.cpp 14a0fbb 
  src/autotests/DBusTest.cpp 814e4f2 
  src/autotests/TerminalInterfaceTest.cpp 2cce10a 

Diff: https://git.reviewboard.kde.org/r/128787/diff/


Testing
-------


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160828/d7979dcc/attachment.html>