Review Request 128778: Make the URL hints key modifiers configurable

[Kurt Hindenburg]

> On Aug. 27, 2016, 8:38 p.m., Kurt Hindenburg wrote:
> > Basically looks fine - 1) could you layout the choices in a more compact way - perhaps horizontal 2) If set, they don't appear enabled in the Advanced tab 3) perhaps remove the now unused EnabledUrlHints= in the .profile
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     How should I go about doing 3)? I thought about checking if EnableUrlHints was set and in that case set the modifiers to just Ctrl to preserve the behavior, but it wasn't obvious how to cleanly check for that.

If I recall correctly, it is just something like this:

    // Remove unused keys
    if (configGroup.hasKey("Transparent")) {
        configGroup.deleteEntry("Transparent");
    }


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128778/#review98730
-----------------------------------------------------------


On Aug. 27, 2016, 9:03 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128778/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2016, 9:03 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Instead of hardcoding CTRL which was a bit annoying add checkboxes to the profile edit dialog to let the user select which keys to use.
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h 1195c14 
>   src/EditProfileDialog.cpp a85cd5b 
>   src/EditProfileDialog.ui 1acec37 
>   src/Profile.h de74afa 
>   src/Profile.cpp 06fe5b1 
>   src/TerminalDisplay.h 93c98ab 
>   src/TerminalDisplay.cpp 4f28837 
>   src/ViewManager.cpp b1efc0a 
> 
> Diff: https://git.reviewboard.kde.org/r/128778/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160828/b0d5c995/attachment.html>