Review Request 128667: Fix crash when closing a session

Martin Tobias Holmedahl Sandsmark martin.sandsmark at kde.org
Sat Aug 27 14:58:34 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128667/
-----------------------------------------------------------

(Updated Aug. 27, 2016, 2:58 p.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole and Kurt Hindenburg.


Changes
-------

Submitted with commit b2b852cfd7b10fc2ffb668ac87f8ca9236a134e3 by Martin T. H. Sandsmark to branch master.


Bugs: 366706
    http://bugs.kde.org/show_bug.cgi?id=366706


Repository: konsole


Description
-------

Instead of manually deleting the output suspended label let the QObject cleanup handle it.

Now it is first deleted manually by us, leading to a potential crash, and afterwards the QObject cleanup runs, but luckily it doesn' try to destroy it again.


Diffs
-----

  src/TerminalDisplay.cpp 4f28837 

Diff: https://git.reviewboard.kde.org/r/128667/diff/


Testing
-------


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160827/2c8ea2c5/attachment-0001.html>


More information about the konsole-devel mailing list