Review Request 128674: Remove unused environment reading code

Kurt Hindenburg kurt.hindenburg at gmail.com
Sat Aug 20 16:09:07 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128674/#review98509
-----------------------------------------------------------



Can you go ahead and commit the environment patch?  If possible put in 2 other reviews w/ the other 2 patches.  The links aren't valid any longer.  I don't see any major issues at the moment with the 3 patches.

- Kurt Hindenburg


On Aug. 13, 2016, 9:56 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128674/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2016, 9:56 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Bugs: 325442
>     http://bugs.kde.org/show_bug.cgi?id=325442
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> First patch in a series of three to try to clean up the ugly /proc/ parsing stuff discussed in https://bugs.kde.org/show_bug.cgi?id=325442
> 
> Reviewboard isn't too happy about submitting patches that depend on eachother, so here's patch number two: http://ix.io/1dV5 and three: http://ix.io/1dV6
> 
> 
> Diffs
> -----
> 
>   src/ProcessInfo.h 7c846b6 
>   src/ProcessInfo.cpp c89d552 
> 
> Diff: https://git.reviewboard.kde.org/r/128674/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160820/c9fa9035/attachment.html>


More information about the konsole-devel mailing list