Review Request 128394: Improve the look of search results

[Kurt Hindenburg]

> On July 14, 2016, 12:51 a.m., Kurt Hindenburg wrote:
> > When the find window is open and empty, my screen is full of | between every character.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     hmm, which font and color scheme are you using?
> 
> Kurt Hindenburg wrote:
>     liberation mono solarized light - very strange - appears to happen with all my fonts
>     
>     Do you perhaps have extra code on your side?  SessionController.cpp also fails to patch for all of these patches
>     -        _view->screenWindow()->setCurrentResultLine(-1);
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     weird, I just rebased it on top of master and now I see it...
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     weird, seems like there's a ton of tiny RegExpFilter::HotSpots...
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     doh, from my qregularexpression stuff, I'll fix it.

in konsole's src folder do a search for cpp and then backspace 1 - the bottom left curve of the oval around cpp is still there in part - there are other ways to get left-over lines/curves


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128394/#review97366
-----------------------------------------------------------


On Aug. 13, 2016, 7:25 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128394/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2016, 7:25 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> with a dark color scheme (breeze): https://iskrembilen.com/screenshots/konsolesearchdark.png
> 
> with a light color scheme: https://iskrembilen.com/screenshots/konsolesearchlight.png
> 
> 
> Diffs
> -----
> 
>   src/SessionController.cpp cacb51b 
>   src/TerminalDisplay.h 93c98ab 
>   src/TerminalDisplay.cpp 4f28837 
> 
> Diff: https://git.reviewboard.kde.org/r/128394/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160813/695b1ed3/attachment.html>