Review Request 128668: Reimplement warning when closing window with active background tabs

[Martin Tobias Holmedahl Sandsmark]

> On Aug. 13, 2016, 6 p.m., Kurt Hindenburg wrote:
> > If you have 2 tabs open and one running top - try to close that top, you get 1) dialog about top running (list); if you hit "Close current tab" you get a 2nd popup asking if you want to close it due to top running.  Overkill?
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     That already happens without this patch, tho? But I can fix that as well.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     It's this oneliner, do you want a review for it or should I just go ahead and commit?: http://ix.io/1dSh
> 
> Kurt Hindenburg wrote:
>     Oh I see, you are correct - go ahead and commit

that also made me notice that the EOF sending makes the closing of tabs wait 1s if there isn't a shell running, is this one okay as well?: http://ix.io/1dSt


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128668/#review98362
-----------------------------------------------------------


On Aug. 13, 2016, 12:10 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128668/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2016, 12:10 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Bugs: 333023
>     http://bugs.kde.org/show_bug.cgi?id=333023
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Add a separate dialog for warning in case there are open background tabs (that can be ignored with the "do not show again" thingy).
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.cpp cae8a54 
> 
> Diff: https://git.reviewboard.kde.org/r/128668/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160813/2be2905b/attachment.html>