Review Request 128667: Fix crash when closing a session

[Anthony Fieroni]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128667/#review98356
-----------------------------------------------------------




src/TerminalDisplay.cpp (line 432)
<https://git.reviewboard.kde.org/r/128667/#comment66272>

    Keep parenting, you should remove manual deleting or parenting, both will make a leak.


- Anthony Fieroni


On Авг. 13, 2016, 2:04 след обяд, Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128667/
> -----------------------------------------------------------
> 
> (Updated Авг. 13, 2016, 2:04 след обяд)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Bugs: 366706
>     http://bugs.kde.org/show_bug.cgi?id=366706
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Instead of manually deleting the output suspended label let the QObject cleanup handle it.
> 
> Now it is first deleted manually by us, leading to a potential crash, and afterwards the QObject cleanup runs, but luckily it doesn' try to destroy it again.
> 
> 
> Diffs
> -----
> 
>   src/TerminalDisplay.cpp 4f28837 
> 
> Diff: https://git.reviewboard.kde.org/r/128667/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160813/7f66de0a/attachment.html>