[Konsole-devel] Review Request 127724: Remove hack for ensuring size before starting session

[Martin Tobias Holmedahl Sandsmark]

> On April 23, 2016, 5:12 p.m., Kurt Hindenburg wrote:
> > It looks good at casual usage - we really want to make sure this doesn't reopen any old bugs.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     Yeah, I tested it in any way I could think of, even with valgrind to "simulate" a slower machine.
>     
>     In theory though it should be exactly the same behavior as before, though, but with a direct function call instead of a timer hack.

I've been running with this patch since I made it, and tested with all the test cases I could come up with (mc, mutt, the test case in https://bugs.kde.org/show_bug.cgi?id=203185, random other ncurses applications).

I'm also sure that the logic is correct.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127724/#review94787
-----------------------------------------------------------


On April 23, 2016, 2:09 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127724/
> -----------------------------------------------------------
> 
> (Updated April 23, 2016, 2:09 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Instead of relying on a hardcoded delay, just use a direct connection to set the window size before starting the session.
> 
> 
> Diffs
> -----
> 
>   src/Emulation.cpp 1989b16 
>   src/Session.cpp 11dc01d 
> 
> Diff: https://git.reviewboard.kde.org/r/127724/diff/
> 
> 
> Testing
> -------
> 
> tested with the cases described in the bugs mentioned.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160428/ad298c85/attachment-0001.html>