[Konsole-devel] Review Request 127627: Fix the DBus auto test

Kurt Hindenburg kurt.hindenburg at gmail.com
Sun Apr 17 11:44:04 UTC 2016



> On April 17, 2016, 10:35 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> > Unless there's any objections, I'll just commit this. It is fairly non-intrusive and just fixes the test.

go ahead - thanks


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127627/#review94658
-----------------------------------------------------------


On April 14, 2016, 10:10 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127627/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 10:10 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> The DBus auto test seems to rely on konsole forking to the background when launched, so we need to use startDetached, and also use the --separate argument to ensure that it spawns a new process.
> 
> 
> Diffs
> -----
> 
>   src/autotests/DBusTest.cpp ff44eba 
> 
> Diff: https://git.reviewboard.kde.org/r/127627/diff/
> 
> 
> Testing
> -------
> 
> The test passes again.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160417/2b1e3a6d/attachment.html>


More information about the konsole-devel mailing list