[Konsole-devel] Review Request 127626: Fix crash when KDBusService exits

[Martin Tobias Holmedahl Sandsmark]

> On April 10, 2016, 3:36 p.m., David Faure wrote:
> > -2
> > 
> > This is only good as a way to confirm a theory. Let's fix this properly in KDBusService instead, though.

Any idea how, or where I should look? The only ideas I have so far is to either install an at_exit() handler in Qt to ensure that the xcb thread is stopped before the rest of the exit handlers are run (but that doesn't really feel like a robust solution), or to use quick_exit() in KDBusService (which feels even uglier).


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127626/#review94490
-----------------------------------------------------------


On April 10, 2016, 3:29 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127626/
> -----------------------------------------------------------
> 
> (Updated April 10, 2016, 3:29 p.m.)
> 
> 
> Review request for Konsole, David Faure and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Fix crash when KDBusService exits.
> 
> This is a bit of an ugly workaround, but it seems to work.
> 
> I'll paste in my comment from https://git.reviewboard.kde.org/r/127625/ here:
> 
>     It seems like it is this that it happening: https://bugreports.qt.io/browse/QTBUG-48709
> 
>     From my understanding it can't really be fixed, short of somehow getting KDBusService to delete the QApplication before calling exit(), which might get nasty with QApplications allocated on the stack?
> 
>     In any case it seems to be a general bug with KDBusService and how it is supposed to be used, not something that we can easily fix in konsole.
> 
> 
> Diffs
> -----
> 
>   src/main.cpp 5e1420e37363454cf5e7886a82381cb9eb4447d8 
> 
> Diff: https://git.reviewboard.kde.org/r/127626/diff/
> 
> 
> Testing
> -------
> 
> Tested by forcing it to open a new window in an existing session (commenting out line 237 in main.cpp), and running under valgrind to verify the deletion.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160410/62e1093f/attachment.html>