[Konsole-devel] Review Request 127625: Port away from kdelibs4support

[Martin Tobias Holmedahl Sandsmark]

> On April 10, 2016, 2:31 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> > I thought I had fixed the semi-random crashes by moving the KDBusService creation to before the creation of most of the other objects on the stack, but it still happens for some reason.
> > The crash happens often, but not always, when instantiating KDBusService with KDBusService::Unique, and I have honestly no idea why it happens, but it happens in the cleanup of static data, I think?
> > 
> > The (almost useless) backtrace is like this, most of the time:
> > 
> > 
> > (gdb) thread apply all bt
> > 
> > Thread 2 (Thread 0x7f1748fda800 (LWP 11861)):
> > #0  0x00007f1748eb9604 in _dl_sort_fini () from /lib64/ld-linux-x86-64.so.2
> > #1  0x00007f1748eb98ea in _dl_fini () from /lib64/ld-linux-x86-64.so.2
> > #2  0x00007f17420a7c38 in __run_exit_handlers () from /usr/lib/libc.so.6
> > #3  0x00007f17420a7c85 in exit () from /usr/lib/libc.so.6
> > #4  0x00007f1745872cd3 in KDBusService::KDBusService(QFlags<KDBusService::StartupOption>, QObject*) () from /usr/lib/libKF5DBusAddons.so.5
> > #5  0x00007f1748c7a98a in kdemain (argc=1, argv=0x7ffce18424b8) at ../src/main.cpp:110
> > #6  0x0000000000400a58 in main (argc=1, argv=0x7ffce18424b8) at src/konsole_dummy.cpp:3
> > 
> > Thread 1 (Thread 0x7f1733a0c700 (LWP 11862)):
> > #0  0x00007f173532ea99 in ?? ()
> > #1  0x00007f1733a0be10 in ?? ()
> > #2  0x00000000020703a0 in ?? ()
> > #3  0x00007f1733a0be50 in ?? ()
> > #4  0x0000000002070710 in ?? ()
> > #5  0x00007ffce184193f in ?? ()
> > #6  0x00007f1742d5ade8 in ?? () from /usr/lib/libQt5Core.so.5
> > 
> > (gdb) 
> > 
> > I'm fairly certain that it is not a bug in the konsole code, but we might be constructing something in the wrong order or something.
> > 
> > But in any case it doesn't really affect the functionality, except that it clutters up coredumpctl with useless coredumps.

I just checked, and I can't find any static objects in the Konsole source, so I'm fairly certain that the bug doesn't lie there.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127625/#review94486
-----------------------------------------------------------


On April 10, 2016, 2:31 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127625/
> -----------------------------------------------------------
> 
> (Updated April 10, 2016, 2:31 p.m.)
> 
> 
> Review request for Konsole, Kai Uwe Broulik, David Faure, and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Continuation of https://git.reviewboard.kde.org/r/126808/ 
> 
> Pretty much all of this is done by D?vis Mos?ns in that review, I just fixed some of the issues with it:
> 
>  * The names of the command line arguments.
>  * Warning about empty argument lists when opening a new window in an existing instance.
>  * An unimportant crash when opening a new window in an existing instance (it was happening on exit).
>  * Creation/adding of the actions for the standalone Konsole application.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 273214c 
>   src/Application.h b7389ef 
>   src/Application.cpp 326c766 
>   src/CMakeLists.txt 6798079 
>   src/MainWindow.h 500b395 
>   src/MainWindow.cpp d2143b8 
>   src/SessionController.h 02f51d9 
>   src/SessionController.cpp 27f9e9f 
>   src/SessionListModel.cpp fb28bb8 
>   src/autotests/PartTest.cpp b3e7797 
>   src/main.cpp 5e1420e 
>   src/settings/ProfileSettings.cpp d6dafbf 
> 
> Diff: https://git.reviewboard.kde.org/r/127625/diff/
> 
> 
> Testing
> -------
> 
> I have tried to trigger edge cases, and I've been using this daily for over a month.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160410/d6bd2a4e/attachment-0001.html>