[Konsole-devel] Review Request 126808: [WIP] Port away from KDELibs4Support

[Martin Tobias Holmedahl Sandsmark]

> On March 6, 2016, 1:01 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> > src/Application.cpp, line 160
> > <https://git.reviewboard.kde.org/r/126808/diff/2/?file=445178#file445178line160>
> >
> >     The parser only seem to get a "noclose" option.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     I have created an updated patch fixing the issues with the command line arguments: https://paste.kde.org/pbtppl8pc/iaa2xm/raw
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     I've been using the previous patch for a while, just updated it now to get rid of a warning about empty argument lists and a crash: https://paste.kde.org/pocjym2vy/caochh/raw
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     D?vis Mos?ns, if it is okay with you I'll open my own review request for my updated version of your patch here.
>     
>     And sorry for the comment spam here, but for some reason the edit menu doesn't get populated anymore with these patches (both the original one in this review and mine).

I had to update the check for whether the konsolepart was loaded in konsole itself because it is now using a normal QApplication, not a custom class: https://paste.kde.org/puocvbqlm


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126808/#review93213
-----------------------------------------------------------


On Feb. 23, 2016, 7:21 p.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126808/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2016, 7:21 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Port away from KUniqueApplication, and from KCmdLineArgs to
> QCommandLineParser. Remove KDELibs4Support dependency.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c498aba89ed59333f2214f52e1b500ca9876233d 
>   src/Application.h b7389ef3d9a2d12a334fff00af3e2f9817d1289a 
>   src/Application.cpp 326c766fb5ff8669bcbce6f2d4d72f8764681400 
>   src/CMakeLists.txt 679807931585644000be0a38ccd67fe5158b3fa5 
>   src/MainWindow.h 500b39561116ce4ce72fa7d3a742c5a57c2b49ef 
>   src/MainWindow.cpp 822e45d57635dd7328eaec7db3eae41cdf19e61b 
>   src/SessionController.h 02f51d9db679eb32d6403ee1103b40842b0c668e 
>   src/SessionListModel.cpp fb28bb806d270b019978684bfeb1052a83afea03 
>   src/autotests/PartTest.cpp b3e7797bd5c52ca5449996099275888936ae9528 
>   src/main.cpp 5e1420e37363454cf5e7886a82381cb9eb4447d8 
>   src/settings/ProfileSettings.cpp d6dafbf17285192727679f92e91744e6c00b2c50 
> 
> Diff: https://git.reviewboard.kde.org/r/126808/diff/
> 
> 
> Testing
> -------
> 
> compiles/builds and basic things seems to be working
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160409/37e64b81/attachment.html>