[Konsole-devel] Review Request 125716: Use QStandardPaths::writableLocation(QStandardPaths::RuntimeLocation) instead of QDir::tempPath()

[Rex Dieter]

> On Oct. 20, 2015, 2:29 p.m., Kurt Hindenburg wrote:
> > I'll have to look at this more
> > 
> > Returns a directory location where runtime communication files should be written, like Unix local sockets. This is a generic value. The returned path may be empty on some systems.
> > 
> > 
> > "/run/user/<USER>", "~/Library/Application Support",	"C:/Users/<USER>"
> 
> Xuetian Weng wrote:
>     Emm.. ok, didn't know that runtime location are persistent on other platforms. Probably make Qt's TempLocation to make use of XDG_RUNTIME_DIR would be a better solution.

Fwiw, I'd previously suggested using QStandardPaths::writableLocation(QStandardPaths::CacheLocation), but that was rejected too.


- Rex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125716/#review87143
-----------------------------------------------------------


On Oct. 20, 2015, 8:40 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125716/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 8:40 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> QStandardPaths::writableLocation(QStandardPaths::RuntimeLocation) can make use of XDG_RUNTIME_DIR, which is a more restricted place that only visible to current user.
> 
> 
> Diffs
> -----
> 
>   src/History.cpp d00b95a 
>   src/settings/FileLocationSettings.cpp aab62c2 
> 
> Diff: https://git.reviewboard.kde.org/r/125716/diff/
> 
> 
> Testing
> -------
> 
> XDG_RUNTIME_DIR is now being used.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20151028/9f0c5d85/attachment.html>