[Konsole-devel] Review Request 123480: Replace theme preview with a pixmap what shows all the backgrounds, consisntent with the one used for SystemSettings > Colors

[Thomas Pfeiffer]

> On April 24, 2015, 8:53 p.m., andreas kainz wrote:
> > Hi we have two discussions in the VDG about system settings.
> > 1. System setting navigation (https://community.kde.org/KDE_Visual_Design_Group/System_Settings_Application)
> > 2. Module layout
> > 
> > the Module layout HIG isn't finished yet. But the results are to have a header, description, preview and a selection area.
> > 
> > I think you made a good start to reduce the existing code and want to have an better user experience.
> > 
> > You offer an more detailed selection area. I'd prevere to have an selection area with less information (only the main color informations like background and text color) and a preview area with all informations.
> 
> Rodrigo Fernandes wrote:
>     Understood, makes sense.
>     
>     Assuming you are too busy to do some konsole specific mockups, I can try a couple of things based on your description + the VDG. Sounds good ?
> 
> andreas kainz wrote:
>     maybe this thread can help. The mouse cursor theme kcm should be the template for the other modules. so the result of the discussion is to make some "big" previews where you can see the result and the user can select the favorite one.
>     https://forum.kde.org/viewtopic.php?f=285&t=126112
>     
>     to be honest I don't know for what the different colors are used for. In my terminal I have a background color and a text color.
> 
> Rodrigo Fernandes wrote:
>     To make it a bit more clear heavy terminal users rely on colour configuration as many advanced console programs, such music players, irc clients, vim / emacs, use them quite a bit. It is also often used to complement the current DE theme. Here are some examples taken from http://www.reddit.com/r/unixporn
>     
>       http://i.imgur.com/ZcOfzhV.png
>       http://imgur.com/a/gflC1#1
>     
>     As suggested I redesigned the preview to focus on Foreground / Background. It's certainly cleaner, please see the attached image.
>     I can still make room for a preview, but the current preview on hover behaviour feels "sufficient", and I fear it would make the configuration window needlessly big.
>     
>     However, I'd like to suggest unifying font configuration with colour settings, packaging them all as theme, this would clear the bottom space for a nice preview window.
>     This would also mean that each theme may have a separate font configuration (which might not be a good thing).
>     
>     Related to these changes I could also work towards:
>     
>       - GHNS for konsole themes.
>       - Adding add a theme Import... button to import konsole .schema files (and other formats, like XResource files colours)
>       - Rename New... to Duplicate, as it uses the currently selected theme as a starting point.
>     
>     Please let me know your opinions / suggestions.
>     
>     Thanks.

The new version is definitely better for the majority of users (i.e. those who rarely see other colors than the standard foreground/background ones). Plus, those who rely on the other color roles get a better impression by just firing up emacs and then using the hover effect than by looking at a bunch of colors randomly packed together.

Also big +1 for putting all appearance stuff into a theme which can be shared via GHNS (but which can still be edited by the user). We're always all for that!


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123480/#review79478
-----------------------------------------------------------


On May 4, 2015, 2:42 p.m., Rodrigo Fernandes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123480/
> -----------------------------------------------------------
> 
> (Updated May 4, 2015, 2:42 p.m.)
> 
> 
> Review request for Konsole and KDE Usability.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Simplify theme preview
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h 5fed35d 
>   src/EditProfileDialog.cpp 62b72f3 
>   src/EditProfileDialog.ui dc5af01 
> 
> Diff: https://git.reviewboard.kde.org/r/123480/diff/
> 
> 
> Testing
> -------
> 
> This patch replaces the theme preview with a similar one to System Settings > Colors.
> 
> Benefits:
>  Code reduction, lots of bespoke code removed
>  Consistency with existing ui presentation.
>  Displays the full color range as opposed to only foreground background
>  
> Drawbacks:
>  Static pixmax might not render as well in HiDPI screens.
> 
> Any feedback is greatly appreciated. 
> Please consider it for inclusion into Konsole.
> 
> Also this is my first review through RB, please mention anything I might has missed.
> 
> Regards,
>  Rodrigo
> 
> 
> File Attachments
> ----------------
> 
> Updated theme preview
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/5651aa87-7199-457f-b563-6c144016a06c__snapshot1.png
> Foreground / Background Theme preview
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/04/29bd16e5-bb95-49a7-9d5f-c2eecab0f83d__snapshot2.png
> 
> 
> Thanks,
> 
> Rodrigo Fernandes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150504/4089825a/attachment.html>