[Konsole-devel] Review Request 123389: High precision wheel event handling in konsole

[Lindsay Roberts]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123389/#review79695
-----------------------------------------------------------


I note that you're not trying to make use of the values in QWheelEvent::pixelDelta() - so this patch only really fixes the smoothness of the keyboard/mouse event emulation slightly.

Is that just because making more invasive changes into how the scroll works is something you'd like to separate from this?


src/TerminalDisplay.h (line 912)
<https://git.reviewboard.kde.org/r/123389/#comment54540>

    Would suggest a more explicit name, `TerminalDisplay::_delta` is slightly ambiguous.



src/TerminalDisplay.cpp (line 2422)
<https://git.reviewboard.kde.org/r/123389/#comment54607>

    In this mechanism, scroll can sit accumulated for days, to apply to a tiny action later.
    
    Have no idea how much of an issue this is, however.



src/TerminalDisplay.cpp (line 2447)
<https://git.reviewboard.kde.org/r/123389/#comment54606>

    In this fork, `_delta` will constantly accumulate, even though the motions is being acted on by QScrollBar::event().


- Lindsay Roberts


On April 16, 2015, 7:14 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123389/
> -----------------------------------------------------------
> 
> (Updated April 16, 2015, 7:14 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Qt5 support high precision wheel event for touchpad. It makes this problem more common.
> 
> Here we use 120 to round the angleDelta, and _delta to store the accumulated delta value.
> 
> 
> Diffs
> -----
> 
>   src/TerminalDisplay.h c043803 
>   src/TerminalDisplay.cpp fa84296 
> 
> Diff: https://git.reviewboard.kde.org/r/123389/diff/
> 
> 
> Testing
> -------
> 
> Test with touchpad scrolling.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150501/76c9afd7/attachment-0001.html>