[Konsole-devel] Review Request 122711: Fixing Ctrl+Space in Konsole

[Jonathan Riddell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122711/#review76888
-----------------------------------------------------------


This works great for me, I plan to include it in Kubuntu packages as I'm an emacs user and it affects me a lot

- Jonathan Riddell


On Feb. 24, 2015, 8:48 p.m., Chirag Anand wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122711/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2015, 8:48 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Bugs: 341157
>     http://bugs.kde.org/show_bug.cgi?id=341157
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> 'QByteArray::replace(int pos, int len, const char * after)' does not copy '\0' bytes. Ctrl+Space which is "\x00" is nothing but a null byte, was not being stored properly in the byte array. Plus, there was an unnecessary fromUnicode call for conversion from QByteArray to QByteArray which was returning a byte array of size 0.
> 
> 
> Diffs
> -----
> 
>   src/KeyboardTranslator.cpp 5bdc62b 
>   src/Vt102Emulation.cpp d0d60ce 
> 
> Diff: https://git.reviewboard.kde.org/r/122711/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chirag Anand
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150302/3d60499c/attachment.html>