[Konsole-devel] Review Request 124142: Fix storing of changed default profile

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124142/#review81892
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Kügler


On June 21, 2015, 5:45 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124142/
> -----------------------------------------------------------
> 
> (Updated June 21, 2015, 5:45 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Bugs: 303356
>     http://bugs.kde.org/show_bug.cgi?id=303356
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> If for some reason no profile is loaded, i. e. only the built-in
> fallback default values are used, we need to create a new profile to
> ensure that changes to the profile are actually persisted.
> 
> This has worked more or less by chance for most people so far, because
> the default is to load the Shell.profile that is shipped with Konsole.
> But if for example the konsolerc config file has an empty value for
> DefaultProfile it will load the builtin fallback profile, which can't be
> saved.
> 
> 
> Diffs
> -----
> 
>   src/Profile.cpp 13c51c8 
>   src/ProfileManager.cpp 0a3c125 
> 
> Diff: https://git.reviewboard.kde.org/r/124142/diff/
> 
> 
> Testing
> -------
> 
> Deleted all profiles, set empty DefaultProfile in konsolerc, change some settings in the profile, close konsole, and restart konsole and see that my changes persist.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150630/a7264c1f/attachment.html>