[Konsole-devel] Review Request 124132: Open URLs with KRun::openUrl instead of new KRun()

[Martin Tobias Holmedahl Sandsmark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124132/#review81868
-----------------------------------------------------------



src/Filter.cpp (line 424)
<https://git.reviewboard.kde.org/r/124132/#comment56202>

    The old code already does mime detection properly by inspecting the actual contents of the URL, your new version tries to guess by the path in the URL, which won't work most of the time.


- Martin Tobias Holmedahl Sandsmark


On June 27, 2015, 10:43 p.m., Jordan Hewitt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124132/
> -----------------------------------------------------------
> 
> (Updated June 27, 2015, 10:43 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Bugs: 347715
>     http://bugs.kde.org/show_bug.cgi?id=347715
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> When opening a link in konsole on Plama 5, konsole would freeze and link wouldn't open (possibly related to bug 347715 ?). This patch fixes that.
> 
> 
> Diffs
> -----
> 
>   src/Filter.cpp 3a3d464 
> 
> Diff: https://git.reviewboard.kde.org/r/124132/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jordan Hewitt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150629/c56d8d89/attachment.html>