[Konsole-devel] Review Request 124132: Open URLs with KRun::openUrl instead of new KRun()

Martin Tobias Holmedahl Sandsmark martin.sandsmark at kde.org
Sun Jun 21 17:47:57 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124132/#review81628
-----------------------------------------------------------



src/Filter.cpp (line 423)
<https://git.reviewboard.kde.org/r/124132/#comment55942>

    you assume that all URLs are text/html?


- Martin Tobias Holmedahl Sandsmark


On June 19, 2015, 9:34 p.m., Jordan Hewitt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124132/
> -----------------------------------------------------------
> 
> (Updated June 19, 2015, 9:34 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Bugs: 347715
>     http://bugs.kde.org/show_bug.cgi?id=347715
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> When opening a link in konsole on Plama 5, konsole would freeze and link wouldn't open (possibly related to bug 347715 ?). This patch fixes that.
> 
> 
> Diffs
> -----
> 
>   src/Filter.cpp 3a3d464 
> 
> Diff: https://git.reviewboard.kde.org/r/124132/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jordan Hewitt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150621/08329e8d/attachment-0001.html>


More information about the konsole-devel mailing list