[Konsole-devel] Review Request 123804: Store History in cache instead of tmp

[Martin Tobias Holmedahl Sandsmark]

> On July 15, 2015, 2:33 a.m., Kurt Hindenburg wrote:
> > I don't think this a good idea to have this as the default.  It will now fill up the user's home space.
> > 
> > Also I would prefer you not commit things like this w/o comments.
> 
> Rex Dieter wrote:
>     You think filling /tmp is safer?  At least 2 distros needed this (fedora and debian so far), do you have any better suggestions to handle this?
>     
>     sorry for the rush, I guess I should have pinged at least once more before moving forward.
> 
> Kurt Hindenburg wrote:
>     CAn you link why those distro use a small /tmp?  It has been a while since I last looked at this but I thought we'd rather have /tmp fill up rather than users's home location ("~/.cache/<APPNAME>").
>     A new release is coming out soon - we'll have to decide on something or  give the users to pick where they want to store it.
> 
> Rex Dieter wrote:
>     Distros are starting to use smaller (VM-backed) tmpfs for /tmp (as indicated in my initial post here).  so, storing potentially unlimited-size items there is bad.  /var/tmp would be better (than /tmp), but I couldn't find any api/standard for using that.  
>     
>     If it helps, if using cache as proposed here, users *do* technically have a choice, they can define a custom XDG_CACHE_DIR environment variable (they could with TMPDIR too, but that has larger downsides and consequences, ie, makes /tmp essentially not used for anything).
> 
> Rex Dieter wrote:
>     Background on tmpfs feature for fedora, https://fedoraproject.org/wiki/Features/tmp-on-tmpfs

I'm pretty sure most applications handles /tmp being full better than the partition the home folder is on, tbh. I'd rather have something hang because it can't create a socket than data loss because some application can't save its data.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123804/#review82516
-----------------------------------------------------------


On July 14, 2015, 7:43 p.m., Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123804/
> -----------------------------------------------------------
> 
> (Updated July 14, 2015, 7:43 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Bugs: 173283
>     http://bugs.kde.org/show_bug.cgi?id=173283
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Some distros have small /tmp and/or use tmpfs, and large history
> (esp unlimited scrollback) can potentially fill disk or VM.
> 
> 
> Diffs
> -----
> 
>   src/History.cpp da7fb7b 
> 
> Diff: https://git.reviewboard.kde.org/r/123804/diff/
> 
> 
> Testing
> -------
> 
> Confirmed history no longer uses /tmp
> 
> 
> Thanks,
> 
> Rex Dieter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150717/65c18231/attachment-0001.html>